Skip to content

Commit

Permalink
ALSA: hda/conexant - Use cached pin control for Node 0x1d on HP Elite…
Browse files Browse the repository at this point in the history
…One 1000 G2

commit 164cd0e077a18d6208523c82b102c98c77fdd51f upstream.

The cached version avoids redundant commands to the codec, improving
stability and reducing unnecessary operations. This change ensures
better power management and reliable restoration of pin configurations,
especially after hibernation (S4) and other power transitions.

Fixes: 9988844c457f ("ALSA: hda/conexant - Fix audio routing for HP EliteOne 1000 G2")
Suggested-by: Kai-Heng Feng <[email protected]>
Suggested-by: Takashi Iwai <[email protected]>
Signed-off-by: Vasiliy Kovalev <[email protected]>
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
  • Loading branch information
Vasiliy Kovalev authored and gregkh committed Oct 22, 2024
1 parent 25e86fb commit 2abe57d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion sound/pci/hda/patch_conexant.c
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@ static void cxt_fixup_update_pinctl(struct hda_codec *codec,
* This is the value stored in the codec register after
* the correct initialization of the previous windows boot.
*/
snd_hda_set_pin_ctl(codec, 0x1d, AC_PINCTL_HP_EN);
snd_hda_set_pin_ctl_cache(codec, 0x1d, AC_PINCTL_HP_EN);
}
}

Expand Down

0 comments on commit 2abe57d

Please sign in to comment.