Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an instruction count cycle to SP1 to ease comparison between Valida ISA and RISC-V ISA.
This is interesting due to the following
Video
keccak-ISA-efficiency-bench.mp4
Instructions count:
Valida (native): 15289
SP1 (native): 16800 keccak, 24100 total
SP1 (precompile): 706 keccak, 7916 total
What can we conclude from this?
In general we cannot compare 2 zkvms on raw instruction count and infer efficiency, this can be seen with SP1 keccak precompile with 3x less instructions yet slower proof generation for a single keccak than native execution.
However, for RISC-like instructions (so no complex super instructions like Keccak), and on the same proof system (Plonky3), less instructions usually mean less work for the prover.