Modifications to be able to run cargo test on Reth primitives crate
#2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We build a lot more dependencies for a test build compared to a normal library build, a lot of which needed to be forked for valida. We also need to register a getrandom implementation, just like we would as if we were creating a binary crate build. Included for convenience is also a cargo config.toml to allow us to simply run cargo with no extra RUSTFLAGS etc.
marcinbugaj
reviewed
Dec 19, 2024
| runner = "/valida-toolchain/valida-runner.sh" | ||
| linker = "/valida-toolchain/bin/ld.lld" | ||
| rustflags = [ | ||
| "-C", "link-arg=/valida-toolchain/ValidaEntryPoint.o", |
There was a problem hiding this comment.
Missing io.o. That's not reported because of --noinhibit-exec 👯♂️
There was a problem hiding this comment.
Perhaps it does not affect this PR yet if it's based on older toolchain but on the most recent one it will
There was a problem hiding this comment.
Good catch, I've added it because that patch got merged to the toolchain
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first step to be able to test the list of crates that we're interested in. The majority of the changes required were simply in various dependencies, to be able to compile them for Valida, since performing a
cargo testbuild involves a lot more dependencies than a standard build.Currently
cargo teston Reth primitives is not passing, something to do with threading. But it does compile and reach the testing phase.