-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new combo and combo skip to HitObject
#113
Conversation
I've made some changes here. Before, this pull included breaking changes: I've also gone ahead and parsed the combo skip for every hitobject. Even if combo skip values are unused for certain hitobjs by osu stable, as long as they are present in the I haven't tested this besides making sure code tests pass, so probably worth a double check to ensure I didn't break anything. |
thanks for the this looks good to me |
Seemed like this was missing. I need new combos for my project.
Spinners dont parse the combo skip value because this mimics osu! stable behaviour.
Hold notes also dont parse the combo information.
Closes #112