Parse background and video events #122
Conversation
|
Thanks! @OliBomby would you be interested in the commit bit on slider? I have less time to maintain it that I used to and you've sent good PRs over the years. |
slider/beatmap.py
Outdated
| background = None | ||
| video = None | ||
| if 'Events' in groups: | ||
| for line in groups['Events']: | ||
| if line.startswith('0'): | ||
| background = line.split('\"')[1] | ||
| elif line.startswith('Video') or line.startswith('1'): | ||
| video = line.split('\"')[1] | ||
|
|
There was a problem hiding this comment.
can there ever be more than one background or video? I supported multiple in #69. I only ask because it matters whether we expose .background or .backgrounds to the user.
There was a problem hiding this comment.
I did some tests in osu! stable and it seems to only load the first background in the file and for videos im not sure, because it seems to support multiple videos but the second video wouldn't play for me, at most showing a black screen or a single frame.
I have a vague memory of some issue thread that wanted to fix multiple videos, but I can't find it.
I use slider for my projects so it would be nice to have the ability to quickly make changes and push out new versions on pip. However i don't plan on actively closing issues beyond the ones I encounter in my projects. |
Every good beatmap at least has a background