[CIR][ABI][AArch64][Lowering] support for calling struct types in range (64, 128) #1141
Conversation
There was a problem hiding this comment.
This is basically the same as #1059 except for argument passing instead of return values, right?
This diff looks fine to me (though I'll give others some time to chime in). For future work I'm wondering if we can unify some of the argument and return paths, but I haven't looked into it very much (and it's not something you need to worry about for this diff).
Yes, you are correct. Actually, in the original CodeGen they are both done in CreateCoercedLoad, and ideally they should be together. |
smeenai
force-pushed
the
main
branch
2 times, most recently
from
4aca8d4
to
a04cf10
Compare
bruteforceboy
force-pushed
the
struct-call-65
branch
2 times, most recently
from
ae76410
to
5d47b2a
Compare
) The title describes the purpose of the PR. It adds initial support for structures with padding to the call convention lowering for AArch64. I have also _initial support_ for the missing feature [FinishLayout](https://github.com/llvm/clangir/blob/5c5d58402bebdb1e851fb055f746662d4e7eb586/clang/lib/AST/RecordLayoutBuilder.cpp#L786) for records, and the logic is gotten from the original codegen. Finally, I added a test for verification.
This PR adds support for the lowering of AArch64 calls with structs having sizes greater than 64 and less than 128.
The idea is from the original CodeGen, where we perform a coercion through memory for these type of calls.
I have added a test for this.