[RISCV] Update matchSplatAsGather to convert vectors if they have different sizes #117878
+393
−1,092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch changes matchSplatAsGather to use vrgather no only when we see an EXTRACT_VECTOR_ELT but also for RISCVISD::VMV_X_S.
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
Signed-off-by: Mikhail R. Gadelha <[email protected]>
Signed-off-by: Mikhail R. Gadelha <[email protected]>
|
I think the title needs updated, this is just modifying the matchSplatAsGather combine right? |
Signed-off-by: Mikhail R. Gadelha <[email protected]>
lukel97
reviewed
Nov 27, 2024
| ; CHECK-NEXT: vrgather.vi v11, v9, 7 | ||
| ; CHECK-NEXT: vmseq.vv v11, v8, v11 | ||
| ; CHECK-NEXT: vmor.mm v10, v10, v11 | ||
| ; CHECK-NEXT: vrgather.vi v11, v9, 8 |
There was a problem hiding this comment.
I think 8 here is past VLMAX for this vector, so I think this will just splat 0 per the spec:
The source vector can be read at any index < VLMAX regardless of vl.
If an element index is out of range ( vs1[i] ≥ VLMAX ) then zero is returned for the element value.
The minimum vlen is 128, the SEW is 8 and LMUL=MF2, so VLMAX = 128 / 8 / 2 = 8. I think we need to check that Vec fits inside VT and bail if it doesn't
mikhailramalho
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.