Fix #416 - Only add Link path if the path is ASCII compatible

lochmueller · Oct 27, 2024 · 4bf87fc · 4bf87fc
1 parent 3933d9b
commit 4bf87fc
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/Classes/Middleware/PrepareMiddleware.php b/Classes/Middleware/PrepareMiddleware.php
@@ -70,7 +70,9 @@ public function process(ServerRequestInterface $request, RequestHandlerInterface
 
         $pushHeaders = (array) $this->httpPushService->getHttpPushHeaders((string) $response->getBody());
         foreach ($pushHeaders as $pushHeader) {
-            $response = $response->withAddedHeader('Link', '<' . $pushHeader['path'] . '>; rel=preload; as=' . $pushHeader['type']);
+            if (mb_detect_encoding($pushHeader['path'], 'ASCII', true)) {
+                $response = $response->withAddedHeader('Link', '<' . $pushHeader['path'] . '>; rel=preload; as=' . $pushHeader['type']);
+            }
         }
 
         return $response;

diff --git a/Classes/Service/HttpPush/AbstractHttpPush.php b/Classes/Service/HttpPush/AbstractHttpPush.php
@@ -14,7 +14,6 @@ public function __invoke(HttpPushHeaderEvent $event): void
         foreach ($event->getExtensions() as $extension) {
             if ($this->canHandleExtension($extension)) {
                 $event->setHeaders(array_merge($event->getHeaders(), $this->getHeaders($event->getContent())));
-                ;
             }
         }
     }

diff --git a/Configuration/Services.yaml b/Configuration/Services.yaml
@@ -165,25 +165,25 @@ services:
   SFC\Staticfilecache\Service\HttpPush\ScriptHttpPush:
     tags:
       - name: event.listener
-        identifier: 'StyleHttpPush'
+        identifier: 'ScriptHttpPush'
         event: SFC\Staticfilecache\Event\HttpPushHeaderEvent
 
   SFC\Staticfilecache\Service\HttpPush\ImageHttpPush:
     tags:
       - name: event.listener
-        identifier: 'StyleHttpPush'
+        identifier: 'ImageHttpPush'
         event: SFC\Staticfilecache\Event\HttpPushHeaderEvent
 
   SFC\Staticfilecache\Service\HttpPush\FontHttpPush:
     tags:
       - name: event.listener
-        identifier: 'StyleHttpPush'
+        identifier: 'FontHttpPush'
         event: SFC\Staticfilecache\Event\HttpPushHeaderEvent
 
   SFC\Staticfilecache\Service\HttpPush\SvgHttpPush:
     tags:
       - name: event.listener
-        identifier: 'StyleHttpPush'
+        identifier: 'SvgHttpPush'
         event: SFC\Staticfilecache\Event\HttpPushHeaderEvent
 
   SFC\Staticfilecache\Generator\ConfigGenerator:
-Original file line number
+Diff line change
@@ Expand Up / @@ -14,7 +14,6 @@ public function __invoke(HttpPushHeaderEvent $event): void @@
             foreach ($event->getExtensions() as $extension) {
                 if ($this->canHandleExtension($extension)) {
                     $event->setHeaders(array_merge($event->getHeaders(), $this->getHeaders($event->getContent())));
-                    ;
                 }
             }
         }
@@ Expand Down @@