Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Added missing middleware implementing frontend.cache.instruction for TYPO3 v13 #418

Merged
merged 4 commits into from
Aug 15, 2024

Conversation

RayTM
Copy link
Contributor

@RayTM RayTM commented Aug 2, 2024

Description

In TYPO3 v13, the frontend.cache.instruction got introduced as a replacement for the now internal TypoScriptFrontendController->no_cache property.
During development / implementation for an TYPO3 v13.2.1 installation i saw, that the middleware hasn't been implemented yet, which results in an error in the backend after installation.

Related Issues

Possibly #410

@lochmueller
Copy link
Owner

Hey @RayTM ,
thanks for the PR. Could you cange the code, so the adaption works also with TYPO v12?
Perhaps check if \TYPO3\CMS\Frontend\Cache\CacheInstruction::class exists and if not, skip the change?
Regards,
Tim

@RayTM
Copy link
Contributor Author

RayTM commented Aug 15, 2024

Hey @lochmueller,
I added a condition that checks if the CacheInstruction class exists, like you advised.
If it is, it adds the frontend.cache.instruction attribute. If not, it skips the change, so it should work with TYPO3 v12 now.

Best regards,
Lukas

@lochmueller
Copy link
Owner

Thanks for the check. Merged!

@lochmueller lochmueller merged commit 7523eb2 into lochmueller:master Aug 15, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants