migrate to ROS2 #16
Merged
migrate to ROS2 #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olivier-stasse
suggested changes
Oct 15, 2024
There was a problem hiding this comment.
Thanks a lot @MaximilienNaveau
You however have to change the license. Specifically if it is done in the frame of Agimus: this is an open source project.
The install procedure is a bit suspicion for the library install.
Other than that it looks geed speed.
|
Actually this packaging should hold for IRON and the CI says so, should I try to add Jazzy in the CI? |
Kotochleb
requested changes
Oct 16, 2024
Co-authored-by: Krzysztof Wojciechowski <[email protected]>
Co-authored-by: Krzysztof Wojciechowski <[email protected]>
Co-authored-by: Krzysztof Wojciechowski <[email protected]>
Co-authored-by: Krzysztof Wojciechowski <[email protected]>
Co-authored-by: Krzysztof Wojciechowski <[email protected]>
Co-authored-by: Krzysztof Wojciechowski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate the msg to ROS 2 targetting humble-devel