Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(backend): backend arm builds, create dockerfile #1831

Merged
merged 16 commits into from
May 11, 2024
Merged

Conversation

corneliusroemer
Copy link
Contributor

@corneliusroemer corneliusroemer commented May 8, 2024

resolves #1765

preview URL: https://backend-arm.loculus.org

Summary

  • Adjust backend docker build to simply repackage a jar (allows building without extra time for ARM)
  • Enable building of backend docker image for ARM

ARM image makes it easy to set up E2E test environment locally on mac with:

./deploy.py --verbose cluster
./deploy.py --verbose helm --branch arm-e2e --for-e2e

@corneliusroemer corneliusroemer added preview Triggers a deployment to argocd and removed preview Triggers a deployment to argocd labels May 8, 2024
@corneliusroemer corneliusroemer added the preview Triggers a deployment to argocd label May 9, 2024
@corneliusroemer corneliusroemer changed the title feat(backend): repackage Jar for arm builds feat(backend): backend arm builds, create dockerfile May 9, 2024
@corneliusroemer corneliusroemer added the review please PR waiting for final review label May 9, 2024
Copy link
Member

@theosanderson theosanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok to me but better reviewed by someone who knows the backend better

(cherry picked from commit 5c299fd)

Use .env file during build

(cherry picked from commit cd834b2)

Build everything for arm as well

chore(ci): use node version from `.nvmrc`

Make a single launcher workflow to launch all arm builds

trigger on push temporarily for testing

f

give broad permissions

try again

test

tag branch with arm

try again

fionally

one more

one more time

I hope

try this

The stupidest thing eve: how should I've known that github.inputs.build_arm needs to be used for workflow call and not github.event.inputs.build_arm

Now

nowwww

Disable debug, finally!
@corneliusroemer corneliusroemer merged commit 1c814c3 into main May 11, 2024
11 checks passed
@corneliusroemer corneliusroemer deleted the backend-arm branch May 11, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview Triggers a deployment to argocd review please PR waiting for final review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build backend container for ARM as well
2 participants