-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(backend): backend arm builds, create dockerfile #1831
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corneliusroemer
added
preview
Triggers a deployment to argocd
and removed
preview
Triggers a deployment to argocd
labels
May 8, 2024
corneliusroemer
force-pushed
the
backend-arm
branch
from
May 9, 2024 22:30
8467b6c
to
9ca23d0
Compare
corneliusroemer
requested review from
fengelniederhammer,
theosanderson and
chaoran-chen
May 9, 2024 22:34
corneliusroemer
changed the title
feat(backend): repackage Jar for arm builds
feat(backend): backend arm builds, create dockerfile
May 9, 2024
corneliusroemer
force-pushed
the
backend-arm
branch
from
May 9, 2024 23:23
9ca23d0
to
bad105c
Compare
theosanderson
approved these changes
May 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems ok to me but better reviewed by someone who knows the backend better
corneliusroemer
force-pushed
the
backend-arm
branch
from
May 10, 2024 16:08
bad105c
to
7a56773
Compare
corneliusroemer
force-pushed
the
backend-arm
branch
from
May 11, 2024 20:37
7a56773
to
05cf85a
Compare
(cherry picked from commit 5c299fd) Use .env file during build (cherry picked from commit cd834b2) Build everything for arm as well chore(ci): use node version from `.nvmrc` Make a single launcher workflow to launch all arm builds trigger on push temporarily for testing f give broad permissions try again test tag branch with arm try again fionally one more one more time I hope try this The stupidest thing eve: how should I've known that github.inputs.build_arm needs to be used for workflow call and not github.event.inputs.build_arm Now nowwww Disable debug, finally!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1765
preview URL: https://backend-arm.loculus.org
Summary
ARM image makes it easy to set up E2E test environment locally on mac with: