Skip to content
This repository has been archived by the owner on Jan 22, 2021. It is now read-only.

Removed package.json to avoid installing outdated node-sass #95

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

KoenLav
Copy link

@KoenLav KoenLav commented Mar 11, 2018

With this package.json in the repository any Meteor application making use of this package will install an outdated version of node-sass, causing the bundle to grow with several megabytes (to include an outdated version of phantomjs).

@brookback
Copy link
Contributor

Oh, I didn't know Meteor is traversing a package tree to find a package.json.

But that'll break the example app – would you mind renaming the directory to .example instead? That'll hide it from Meteor.

@adamgins
Copy link

@brookback any thoughts to accept this?
just linking here #96

@brookback
Copy link
Contributor

@adamgins I'll have a look asap.

@adamgins
Copy link

Thanks @brookback

@bduff9
Copy link

bduff9 commented Aug 9, 2018

Any movement on this? Trying to install lookback and its failing my entire build with the 404 on the node-sass even though node-sass is installed as a dependency in my package.json. Would appreciate any help asap. Thanks!

@brookback
Copy link
Contributor

@bduff9 Feel for trying this branch: fix/hide-example-app, if you clone down this package into the packages dir in your app. I've renamed the example dir to .example to make Meteor ignore it and its package.json file. Thanks!

@noahsw
Copy link

noahsw commented Sep 1, 2018

@brookback but that branch still has

Won't that still include node-sass?

@brookback
Copy link
Contributor

@noahsw It's marked as weak, so afaik, it won't be explicitly depended on.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants