Really bad fix.

louist103 · May 11, 2024 · 0baac02 · 0baac02
1 parent da10949
commit 0baac02
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/mm/src/overlays/actors/ovl_En_Po_Composer/z_en_po_composer.c b/mm/src/overlays/actors/ovl_En_Po_Composer/z_en_po_composer.c
@@ -278,7 +278,11 @@ void EnPoComposer_SetupStartedCutscene(EnPoComposer* this) {
     this->actionFunc = EnPoComposer_StartedCutscene;
 }
 
+// #region 2S2H [Port] There is an issue with MSVC where this function is removed in release mode and the check in EnPoComposer_UpdateAction fails.
+// We need to do something in this function that has a side effect which will cause MSVC to not remove it.
+// This modification seemed cleaner than `volatile int a = 5`. __declspec(noinlne) did not work.
 void EnPoComposer_StartedCutscene(EnPoComposer* this, PlayState* play) {
+    sPlayerIsPlayingOcarina = false;
 }
 
 void EnPoComposer_SetupPlayCurse(EnPoComposer* this) {