Fix sample exporting #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 24, 2024
Archez
reviewed
Sep 24, 2024
ZAPD/ZAudio.cpp
Outdated
|
|
||
| return sample; | ||
| } | ||
| else | ||
| { | ||
| return samples[sampleOffset]; | ||
| return samples[(uint64_t)sampleDataOffset << 32 | 0]; |
There was a problem hiding this comment.
But then everywhere we index it, we are just shifting the value over without adding anything else, so I'm not sure the intent here.
How does this all impact 32 bit platforms (WiiU)?
Archez
reviewed
Sep 25, 2024
Archez
approved these changes
Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of samples were duplicated with attributes for
LoopOffset. This attribute was not used in OOT or MM decomp so it was removed. This is matched by a PR in OTRExporter and they should be merged together.