Fix graphics debugger on 64bit #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Archez
force-pushed
the
fix-gfx-debugger-64bit
branch
from
c625ccb to
c74cb89
Compare
louist103
pushed a commit
that referenced
this pull request
Mar 2, 2024
* fix graphics debugger on 64bit * wrap libgfxd use in define * clang format
louist103
added a commit
that referenced
this pull request
Mar 27, 2024
* MM * Work for MM * Fixed palette issues in MM (#1) * Fixed palette issues with MM * Test * opcode for open/close disps * Gfx Debugger (#2) * BitConverter: fix type correcteness in loop * gbi: get rid of LoadUcode macros * Gui: add ability to make a GuiImage out of a LUS::Texture * Add GfxDebugger * GfxDebugger: add C Bridge * gfx_pc: expose internal state + intergrate debugger * Add GfxDebuggerWindow * Context: integrate GfxDebuggerWindow * update CMakeLists.txt * GfxDebugger: move inline code from header to cpp file * clean up comments and add a check for empty stacks * fix cmake * conflict * implement bg 1cyc (#4) * Implement point lights (#5) * Remove debugging code * Framebuffer Effects 1.0 (#6) * Add initial copy framebuffer and draw framebuffer commands * Implement DirectX framebuffer copy * Implement OpenGL framebuffer copy * Implement Metal framebuffer copy * tweaks for metal viewport and int conversion * resolve opengl msaa * remove unused code paths * Fix graphics debugger on 64bit (#8) * fix graphics debugger on 64bit * wrap libgfxd use in define * clang format * Fix light blinking in clocktown (#9) * Revert changes to ResourceManager.cpp * Format * Fix * merge * ad setFB command * Fix WiiU * fix switch build error (#10) * Remove commented g/abi.h files * fix token pasting error on some compilers (#11) * fix pop back without size check (#12) * fix dl cmd increment (#13) * add custom opcode for managing offset dl calls on 64bit (#14) --------- Co-authored-by: Nicholas Estelami <[email protected]> Co-authored-by: Random <[email protected]> Co-authored-by: Archez <[email protected]> Co-authored-by: Rozelette <[email protected]> Co-authored-by: briaguya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The graphics debugger on 64bit machines was only printing the first word for each instruction. i.e.
gsSP2Triangleswould show zeros for the second triangle. This is because ourGfxusesuintptr_ttypes for the words, but theGfxinternal tolibgfxdusesuint32_t. When the disassembler executes it treats ourw0as the value split over bothw0andw1.To address this, I build a new input buffer as a
vector<uint32_t>and only copy the first 32bits of each word into it, then pass that into the disassembler with the correct size value.I also added the define wrapper around the
libgfxduse so that we can have successful builds in the github actions. The GFX debugger will just print the opcode name when disassembly is not enabled.Plus clang format