Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#105] docs: amp 번역 #107

Merged
merged 5 commits into from
Aug 11, 2024
Merged

[#105] docs: amp 번역 #107

merged 5 commits into from
Aug 11, 2024

Conversation

Ubinquitous
Copy link
Contributor

컨트리뷰션 체크리스트

  • 기여 가이드를 확인한 후 작성 하셨나요?
  • 용어집을 확인한 후 작성 하셨나요? 번역하신 단어 중 용어집에 추가하고싶은 단어가 있으시다면 이슈에 댓글로 남겨주세요.
  • title, description 등 마크다운 태그의 영문 원본 유지를 하셨나요?
  • 소제목 (h1~h6, ### ... 등)의 영문 유지를 하셨나요?
  • 문서의 전반적인 어조 톤과 일치하게 작성 하셨나요?
  • 코드블록 내부의 주석이나 업데이트 로그 등 표 내부의 문자도 한국어로 번역 하셨나요?

연관된 이슈 확인

closes #105

기여 내용

  • 새로운 문서 번역
  • 문서 내용 수정
  • 오타 수정
  • 문서 웹페이지 기능 수정
  • 기타 기능 개선 및 수정

문서 경로

/docs/pages/building-your-application/configuring/amp.mdx

@vercel Vercel
Copy link

vercel bot commented Aug 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextjs-ko ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 9, 2024 3:20am

@luciancah luciancah self-requested a review August 5, 2024 11:32
@luciancah luciancah added the docs 새로운 문서 작업 및 문서 오류 수정 label Aug 5, 2024
luciancah
luciancah requested changes Aug 5, 2024
View reviewed changes
Copy link
Owner

@luciancah luciancah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

안녕하세요, 수정하신 문서의 경로가 pages/docs/app/building-your-application/configuring/amp.mdx 로 보이는데요, app 라우터가 아닌 pages 경로에서 수정이 필요합니다.

@Ubinquitous
Copy link
Contributor Author

앗핫 제가 착각했네요 죄송합니다!!
다시 파일 이동 완료했습니다!

@luciancah luciancah self-requested a review August 6, 2024 05:04
luciancah
luciancah requested changes Aug 7, 2024
View reviewed changes
Copy link
Owner

@luciancah luciancah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

안녕하세요, 기여 감사합니다! 문서 전반적인 스타일 확인 리뷰 부탁드리겠습니다 :)

pages/docs/pages/building-your-application/configuring/amp.mdx Outdated Show resolved Hide resolved
luciancah
luciancah requested changes Aug 8, 2024
View reviewed changes
Copy link
Owner

@luciancah luciancah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

안녕하세요! 수정해주신 부분 잘 확인했습니다. 일부 덜 수정된 부분이 보여서 다시 코멘트 드립니다. 1회 리뷰에 전체 문서를 검수하기 조금 힘든 부분이 있어서, 양해 부탁드리겠습니다.

pages/docs/pages/building-your-application/configuring/amp.mdx Outdated Show resolved Hide resolved
luciancah
luciancah approved these changes Aug 9, 2024
View reviewed changes
Copy link
Owner

@luciancah luciancah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 :) 기여 감사합니다 !

@luciancah luciancah changed the base branch from main to patch-0811 August 11, 2024 09:32
@luciancah luciancah merged commit abf07db into luciancah:patch-0811 Aug 11, 2024
3 checks passed
@luciancah luciancah mentioned this pull request Aug 11, 2024
Merged
luciancah added a commit that referenced this pull request Aug 12, 2024
@luciancah @mini-boo
@grapefruit13 @Ubinquitous @kor-bim @WaterMinCho @jinlee0310 @wlstmd @pySoo @davindev @hyunmyungJaneLee
[#6] docs: 8월 2주차 문서 업데이트 (#120)
09f5832 
* [#90] docs: version-9 번역 (#101)
* [#84] docs: getStaticProps 번역 (#106)
* [#105] docs: amp 번역 (#107)
* [#109] api-routes 번역 (#110)
* [#86] docs: use-router.mdx 번역 (#113)
* [#111] docs: pages-and-layouts 번역 (#114)
* [#115] docs: image-�legacy 번역 (#116)
* [#89] docs: draft-mode 번역 (#117)
* [#87] docs: internationalization 번역 (#118)
* [#88] docs: getInitialProps 번역 (#119)
* [#6] docs: 기여자 정보 추가
* [#115] docs: image-legacy 문법 수정

---------

Co-authored-by: Hyunsoo Kim <[email protected]>
Co-authored-by: grapefruit <[email protected]>
Co-authored-by: 박우빈 <[email protected]>
Co-authored-by: Yoon Han Bin <[email protected]>
Co-authored-by: 조민수 <[email protected]>
Co-authored-by: Jominsu <[email protected]>
Co-authored-by: HyojinLee <[email protected]>
Co-authored-by: Jinseung <[email protected]>
Co-authored-by: Suhyeon Park <[email protected]>
Co-authored-by: vinnie <[email protected]>
Co-authored-by: Arin <[email protected]>
Co-authored-by: Jominsu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luciancah luciancah luciancah approved these changes

Assignees

@Ubinquitous Ubinquitous

Labels
docs 새로운 문서 작업 및 문서 오류 수정
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

/docs/pages/building-your-application/configuring/amp.mdx 문서 번역
2 participants
@Ubinquitous @luciancah