Separate RSA key reading from login decoding #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @notjuanortiz, TravisBuddy Request Identifier: 40f9a230-5b29-11ea-b66e-89572c858fbd |
notjuanortiz
changed the title
|
This issue has been marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. |
|
This issue has been closed because it has not had any recent activity. Feel free to re-open this issue or create another one if the problem isn't resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I had a difficult time writing clean code to programmatically add new RSA keys (#179) due to how tightly-coupled key reading and authentication logic were.
Result
Separates the responsibility of reading RSA keys from authentication logic. It is written in such a way that is open to extensibility and closed for modification so that developers can define custom key read/write implementations without breaking any adjacent systems.
This also introduces a new package
io.luna.security.