-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(root): move logging settings/configuration into a single package #220
base: master
Are you sure you want to change the base?
refactor(root): move logging settings/configuration into a single package #220
Conversation
Hey @notjuanortiz, TravisBuddy Request Identifier: 879c0450-6d33-11ea-8920-b3945d724fa9 |
This issue has been marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. |
This issue has been closed because it has not had any recent activity. Feel free to re-open this issue or create another one if the problem isn't resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but I think the old TOML loading was more clear and concise. Could it be changed back?
By creating an abstraction I've decoupled reading the logging settings from a file from actually starting the server. |
This PR includes a few minor, but related, changes.
LoggingSettings
, andLoggingConfigurationFactory
into a single packageio.luna.logging
TomlLoggingSettingFileReader
to ensure the code works as intended.Contributes to #215 .