Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(root): Introduce files module #222

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

notjuanortiz
Copy link
Contributor

@notjuanortiz notjuanortiz commented Mar 25, 2020

Purpose

Edit: This change is one of many to come that will allow us to maintain a linear dependency tree when migrating the remaining utility classes into their respective packages, as discussed in #180.

Result

Moves abstract file parsers into a new module called files.

This also introduces the buildSrc directory which is automatically detected by gradle.

You can read more about why it exists and how it should be used here: https://docs.gradle.org/current/userguide/organizing_gradle_projects.html#sec:build_sources

This commit also includes a buildSrc directory
@TravisBuddy
Copy link

Hey @notjuanortiz,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 77565890-6ea8-11ea-bef5-ab2a7fe30e4a

@stale
Copy link

stale bot commented Jun 5, 2020

This issue has been marked as stale because it has not had any recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix An issue that went stale or won't be resolved. label Jun 5, 2020
@stale
Copy link

stale bot commented Jun 12, 2020

This issue has been closed because it has not had any recent activity. Feel free to re-open this issue or create another one if the problem isn't resolved.

@stale stale bot closed this Jun 12, 2020
@lare96 lare96 removed the wontfix An issue that went stale or won't be resolved. label Dec 28, 2020
@lare96 lare96 reopened this Dec 28, 2020
@lare96
Copy link
Member

lare96 commented Dec 30, 2020

I'm not gonna merge this for now, just because I want to have a full roadmap of how everything will be refactored first

@lare96 lare96 added the blocked An issue that cannot be resolved yet, usually because of another issue. label Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked An issue that cannot be resolved yet, usually because of another issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants