MimeMessage 생성의 책임을 분리한다. #140
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AbstractMailSender의 sendMail 메서드에서 MimeMessage를 생성하는 로직이 중복되어 객체로 분리했습니다.
추상 클래스인 AbstractMailSender를 구현하는 구현체는 MailSender, QuestionSender, WeeklyQuestionSender 세 개가 있었고,
각각의 Sender에서 생성하는 MimeMessage가 모두 각각의 이유로 달라질 수 있기 때문에
추상 클래스인 MimeMessageCreator를 상속받도록 했습니다.
AbstractMailSender 클래스는 제네릭 타입으로 Message 타입만 사용하고 있었는데,
MimeMessageCreator를 상속하는 타입을 추가로 가지게 변경됐습니다. 🫠