Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update holster, Golang to 1.22. #210

Closed
wants to merge 5 commits into from
Closed

Update holster, Golang to 1.22. #210

wants to merge 5 commits into from

Conversation

Baliedge
Copy link

@Baliedge Baliedge commented Apr 22, 2024 •
edited
Loading

Bring Kafka-Pixy out of the early days of Golang.

Update Holster and update Golang to latest.

Depends on:

@Baliedge Baliedge requested a review from a team April 22, 2024 19:50
@Baliedge
Copy link
Author

Build is breaking due to docker/login action failing on bad credentials in GitHub secrets. Seeing as this repo hasn't been updated in over 2 years, it may be best to leave this update for a later time when it is required.

@Baliedge Baliedge closed this Apr 23, 2024
@jtet jtet reopened this Apr 23, 2024
@Baliedge Baliedge requested a review from MatthewEdge April 23, 2024 15:30
@Baliedge
Copy link
Author

Thanks @jtet for fixing the docker secret. Build is passing now.

@Baliedge
Copy link
Author

Closing this PR for now until the Holster/Golang update becomes a requirement. Good to know the build is fixed.

@Baliedge Baliedge closed this Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtopc vtopc vtopc left review comments

@MatthewEdge MatthewEdge Awaiting requested review from MatthewEdge

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Baliedge @vtopc @jtet