Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add summary and accordions to ProductDetails #433

Merged
merged 10 commits into from
Dec 20, 2024

Conversation

jorgemoya
Copy link
Collaborator

@jorgemoya jorgemoya commented Dec 20, 2024

Update designs of product details to include accordions and summary.

Kapture.2024-12-20.at.14.54.08.mp4
Kapture.2024-12-20.at.15.03.38.mp4

Copy link

linear bot commented Dec 20, 2024

Copy link

vercel bot commented Dec 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vibes ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 9:01pm

@jorgemoya jorgemoya changed the title feat: make product gallery sticky feat: add summary and accordions to ProductDetails Dec 20, 2024
Copy link
Member

@migueloller migueloller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! What do you think @jorgemoya, do you like this better than what we had before?

@jorgemoya jorgemoya merged commit 4177a47 into main Dec 20, 2024
4 checks passed
@jorgemoya jorgemoya deleted the eng-7212-gallery-sticky branch December 20, 2024 21:04
@jorgemoya
Copy link
Collaborator Author

This looks great! What do you think @jorgemoya, do you like this better than what we had before?

A lot better experience imo! Thanks for working on this with @andrewreifman.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants