feat: update Error to use click event handler #445
Merged
+21
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
migueloller
reviewed
Dec 31, 2024
jordanarldt
force-pushed
the
ja/fix-error
branch
from
e2af0c1 to
dcd0bed
Compare
jordanarldt
force-pushed
the
ja/fix-error
branch
from
dcd0bed to
d26249b
Compare
jordanarldt
force-pushed
the
ja/fix-error
branch
from
d26249b to
70e3894
Compare
migueloller
requested changes
Dec 31, 2024
jordanarldt
force-pushed
the
ja/fix-error
branch
from
70e3894 to
01f71c9
Compare
migueloller
requested changes
Dec 31, 2024
jordanarldt
force-pushed
the
ja/fix-error
branch
from
01f71c9 to
22592ca
Compare
jorgemoya
reviewed
Jan 2, 2025
jorgemoya
approved these changes
Jan 2, 2025
jordanarldt
force-pushed
the
ja/fix-error
branch
from
22592ca to
ca143b1
Compare
migueloller
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed NextJS requires Error page to be a client component, so we need to use an onClick handler instead of an href.
Updated
Errorsection to allow a function to be passed in rather than a string.https://nextjs.org/docs/app/building-your-application/routing/error-handling#using-error-boundaries