-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding compatibility for Laravel 5.4 #11
base: master
Are you sure you want to change the base?
Conversation
Maybe release a new version with this fix? I'm using this package to send errors to slack on all my active projects, so they are all breaking on update :) |
Really want the release as well. 😄 |
Can this be released? It's affecting production and we're having to SSH in and hack files. |
@jackmcdade If interested, I have created a fork in the meanwhile to fix our app: https://packagist.org/packages/tlapi/slack-laravel |
Thanks @Tlapi! |
You could also to your composer.json temporarily add:
|
Guys, @maknz said on twitter that he doesn't have time to maintain this package anymore and will soon post a deprecation notice. |
@Tlapi any interest in taking this over? |
@Tlapi Just FYI your composer package, tlapi/slack-laravel, has the old code in the L5 Service Provider. It's still throwing the "share()" error. |
I also created a fork for this at https://github.com/freshworkstudio/slack-laravel You can install it |
oh god, still no one working fork? |
@hotrush I just installed @gonzunigad's fork and so far that seems to be working. At least I didn't get the |
@mcblum only one works for me at 5.4 - jeremykenedy/slack-laravel |
I just made a fork and fixed it there: if anybody is interested: https://github.com/phpify/slack-laravel or just |
@Tlapi i'm still getting this error:
after i've included your library.. ideas? |
damn @Tlapi! if i run this:
so your 1.0.0 is pointing to this commit: Tlapi@d62741f, but this commit DOESN't actually include the changes, it should be this commit instead: Tlapi@6d5e9ff |
so adding this worked:
see this
|
No description provided.