Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding compatibility for Laravel 5.4 #11

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

connorjburton
Copy link

No description provided.

@mhamlet
Copy link

mhamlet commented Jan 30, 2017

Maybe release a new version with this fix? I'm using this package to send errors to slack on all my active projects, so they are all breaking on update :)

@bynelus
Copy link

bynelus commented Jan 31, 2017

Really want the release as well. 😄

@jackmcdade
Copy link

Can this be released? It's affecting production and we're having to SSH in and hack files.

@Tlapi
Copy link

Tlapi commented Feb 13, 2017

@jackmcdade If interested, I have created a fork in the meanwhile to fix our app: https://packagist.org/packages/tlapi/slack-laravel

@jackmcdade
Copy link

Thanks @Tlapi!

@mdrost
Copy link

mdrost commented Feb 22, 2017

You could also to your composer.json temporarily add:

"repositories": [
    {
        "type": "vcs",
        "url": "https://github.com/connorjburton/slack-laravel"
    }
 ],

@AlexDanault
Copy link

Guys, @maknz said on twitter that he doesn't have time to maintain this package anymore and will soon post a deprecation notice.

Link: https://twitter.com/maknz/status/833866298232754177

@carsonreinke
Copy link

@Tlapi any interest in taking this over?

@jonrobinson
Copy link

@Tlapi Just FYI your composer package, tlapi/slack-laravel, has the old code in the L5 Service Provider. It's still throwing the "share()" error.

@gdespirito
Copy link

I also created a fork for this at https://github.com/freshworkstudio/slack-laravel

You can install it composer require freshwork/slack-laravel

@hotrush
Copy link

hotrush commented Jul 31, 2017

oh god, still no one working fork?

@mcblum
Copy link

mcblum commented Aug 6, 2017

@hotrush I just installed @gonzunigad's fork and so far that seems to be working. At least I didn't get the share() error.

@hotrush
Copy link

hotrush commented Aug 6, 2017

@mcblum only one works for me at 5.4 - jeremykenedy/slack-laravel

@skecskes
Copy link

I just made a fork and fixed it there: if anybody is interested: https://github.com/phpify/slack-laravel or just composer require phpify/slack-laravel

@abbood
Copy link

abbood commented Jan 26, 2018

@Tlapi i'm still getting this error:

In SlackServiceProviderLaravel5.php line 27:

  Call to undefined method Illuminate\Foundation\Application::share()

after i've included your library.. ideas?

@abbood
Copy link

abbood commented Jan 26, 2018

damn @Tlapi! if i run this:

$ composer show tlapi/slack-laravel
name     : tlapi/slack-laravel
descrip. : Laravel 4 and 5 integration for the maknz/slack package, including facades and service providers.
keywords : laravel, slack
versions : * 1.0.0
type     : library
license  : BSD 2-clause "Simplified" License (BSD-2-Clause) (OSI approved) https://spdx.org/licenses/BSD-2-Clause.html#licenseText
source   : [git] https://github.com/Tlapi/slack-laravel.git d62741f731c963c71272159b38f8209ce57ff85b
dist     : [zip] https://api.github.com/repos/Tlapi/slack-laravel/zipball/d62741f731c963c71272159b38f8209ce57ff85b d62741f731c963c71272159b38f8209ce57ff85b
names    : tlapi/slack-laravel

autoload
psr-4
Maknz\Slack\Laravel\ => src/

requires
maknz/slack ~1.0
php >=5.4.0

so your 1.0.0 is pointing to this commit: Tlapi@d62741f, but this commit DOESN't actually include the changes, it should be this commit instead: Tlapi@6d5e9ff

@abbood
Copy link

abbood commented Jan 26, 2018

so adding this worked:

"tlapi/slack-laravel": "dev-master#6d5e9ff218a7ed53c630c2192873087bf6f7fb1d"

see this

$ composer show tlapi/slack-laravel
name     : tlapi/slack-laravel
descrip. : Laravel 4 and 5 integration for the maknz/slack package, including facades and service providers.
keywords : laravel, slack
versions : * dev-master
type     : library
license  : BSD 2-clause "Simplified" License (BSD-2-Clause) (OSI approved) https://spdx.org/licenses/BSD-2-Clause.html#licenseText
source   : [git] https://github.com/Tlapi/slack-laravel.git 6d5e9ff218a7ed53c630c2192873087bf6f7fb1d
dist     : [zip] https://api.github.com/repos/Tlapi/slack-laravel/zipball/6d5e9ff218a7ed53c630c2192873087bf6f7fb1d 6d5e9ff218a7ed53c630c2192873087bf6f7fb1d
names    : tlapi/slack-laravel

autoload
psr-4
Maknz\Slack\Laravel\ => src/

requires
maknz/slack ~1.0
php >=5.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.