-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for Laravel 5.5 #23
base: master
Are you sure you want to change the base?
Conversation
Please update. I'm using your package and i'm getting error |
src/ServiceProviderLaravel5.php
Outdated
|
||
$this->app['maknz.slack'] = $this->app->share(function ($app) { | ||
$this->app['maknz.slack'] = $this->app->singleton('maknz.slack', function ($app) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this will work . You don't need to reassign $this->app['maknz.slack']
with the returned value from app->singleton
since you already define the name for the singleton as a parameter to the function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please review my change and accept, have tested locally over tinker, Slack command works
@skmetaly also listed Laravel 5.5, auto package discovery in |
I just made a fork and fixed it there: if anybody is interested: https://github.com/phpify/slack-laravel or just |
The package is no longer being maintained... here is my fork of it..
|
This PR worked well for me and fixed the Laravel 5.5 incompatibility issues. It should be accepted. :) Thanks, @RohanSakhale! |
Please merge. |
@skmetaly could you please merge this PR |
just implemented the same fix on my local and then found the same solution in PR. |
@maknz WTF ARE YOU WAITING FOR TO MERGE THIS. |
@maurocasas You don’t need to wait on him. Just update the dependency in your package manager to be constrained to this specific commit hash. |
If you took 30 seconds to glance at the README, you'd see this package is no longer being maintained as of early 2017. Use one of the (100+) forks that implements the features you want, or make your own. Screaming at me to "WTF ARE YOU DOING MERGE THIS" only serves to discourage me from ever contributing open source code again. |
No description provided.