Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ascender/descender proto defs, logic, & tests #12

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add ascender/descender proto defs, logic, & tests #12

wants to merge 2 commits into from

Conversation

jseppi
Copy link

@jseppi jseppi commented Nov 25, 2019

Closes #11

@springmeyer for review, please

cc @tristen

@jseppi jseppi self-assigned this Nov 25, 2019
@springmeyer
Copy link

PR seems straightforward, so 👍

If any font has a different ascender or descender value, then the composite will have its value set to 0 (which will enable falling back to the hard-coded default values in mapbox-gl-js and mapbox-gl-native).

I have some questions about this, will comment at #11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@springmeyer springmeyer springmeyer approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

@jseppi jseppi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle fontstack ascender/descender metadata
2 participants
@jseppi @springmeyer