Add ascender/descender proto defs, logic, & tests #12
+3,286
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11
ascender
anddescender
fields toglyphs.proto
to match those in Expose ascender/descender metadata properties in protobuf node-fontnik#160ascender
anddescender
as described in Handle fontstack ascender/descender metadata #11:ascender
ordescender
, then the composite will have that value.ascender
ordescender
value, then the composite will have its value set to 0 (which will enable falling back to the hard-coded default values in mapbox-gl-js and mapbox-gl-native).node-fontnik
version in Expose ascender/descender metadata properties in protobuf node-fontnik#160 so that they haveascender
anddescender
values set@springmeyer for review, please
cc @tristen