Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map::layers() doesn't really list ALL layers - added a comment about it #306

Merged
merged 1 commit into from
Aug 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased]
### Changed
- Improved documentation on `Map::layers` and `Map::get_layer`. (#306)

## [0.12.0]
### Added
- Add `text`, `width` and `height` members to `ObjectShape::Text`. (#278)
Expand Down
7 changes: 5 additions & 2 deletions src/map.rs
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,10 @@ impl Map {
self.tilesets.as_ref()
}

/// Get an iterator over all the layers in the map in ascending order of their layer index.
/// Get an iterator over top-level layers in the map in ascending order of their layer index.
///
/// Note: "top-level" means that if a map has layers of `LayerDataType::Group` type, you
/// need to recursively enumerate those group layers.
///
/// ## Example
/// ```
Expand Down Expand Up @@ -139,7 +142,7 @@ impl Map {
self.layers.iter().map(move |layer| Layer::new(self, layer))
}

/// Returns the layer that has the specified index, if it exists.
/// Returns the top-level layer that has the specified index, if it exists.
pub fn get_layer(&self, index: usize) -> Option<Layer> {
self.layers.get(index).map(|data| Layer::new(self, data))
}
Expand Down
Loading