-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDF text rendering plugin #314
base: main
Are you sure you want to change the base?
Conversation
LETS GOOOOOO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool. Just a drive by review, my first peep at maplibre-rs code.
others:
|
2c4d481
to
5085420
Compare
When will this be merged? |
On time for Christmas 🤞 |
@michael-markl pls review |
.layers | ||
.iter() | ||
.find(|layer| layer.source_layer == Some("water".to_string())) | ||
.expect("water layer must exist"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On Mars, no water exists!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True! We must create water on mars first
bb2e07b
to
3fbe3c1
Compare
This PR appear to be working as expected, is anything holding it from review? |
video.webm
TODO:
Q:
The basic implmenetation for SDFs is based on https://github.com/stadiamaps/maps-rs (licensed as MIT OR APACHE)