Skip to content

Commit

Permalink
Fix the docker image port to fix backward compatibility (#502)
Browse files Browse the repository at this point in the history
  • Loading branch information
petrsloup committed Dec 14, 2020
1 parent 7c14209 commit a3d7f8b
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,10 @@ ENV CHOKIDAR_INTERVAL=500
VOLUME /data
WORKDIR /data

EXPOSE 8000
EXPOSE 80

USER node:node

ENTRYPOINT ["/app/docker-entrypoint.sh"]

CMD ["-p", "8000"]
CMD ["-p", "80"]

This comment has been minimized.

Copy link
@joakimfors

joakimfors Jan 8, 2021

Contributor

Can not bind to privileged port as USER is set to node to avoid running as root. Perhaps better to break backwards compatibility and document it instead of reverting to the old more insecure behaviour of running as root/binding to privileged ports.

This comment has been minimized.

Copy link
@alitoufighi

alitoufighi Nov 7, 2021

This prevents current release to be usable in Docker! (At least without tweaking and figuring out what has happened here)

0 comments on commit a3d7f8b

Please sign in to comment.