-
Notifications
You must be signed in to change notification settings - Fork 646
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix the docker image port to fix backward compatibility (#502)
- Loading branch information
Showing
1 changed file
with
2 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -46,10 +46,10 @@ ENV CHOKIDAR_INTERVAL=500 | |
VOLUME /data | ||
WORKDIR /data | ||
|
||
EXPOSE 8000 | ||
EXPOSE 80 | ||
|
||
USER node:node | ||
|
||
ENTRYPOINT ["/app/docker-entrypoint.sh"] | ||
|
||
CMD ["-p", "8000"] | ||
CMD ["-p", "80"] | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
alitoufighi
|
Can not bind to privileged port as
USER
is set tonode
to avoid running as root. Perhaps better to break backwards compatibility and document it instead of reverting to the old more insecure behaviour of running as root/binding to privileged ports.