Skip to content

Commit

Permalink
Simplify signal handling (#771)
Browse files Browse the repository at this point in the history
Avoid implementing a complex signal relaying mechanism in `docker-entrypoint*.sh`
Instead, the shell performs `exec node ...` and the `node` process receives the signals directly.

Related to #560, #575, which were my initial implemetation.
  • Loading branch information
zstadler authored Feb 19, 2023
1 parent acde7b0 commit f242cc1
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion docker-entrypoint.sh
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ if ! which -- "${1}"; then
# first arg is not an executable
export DISPLAY=:99
Xvfb "${DISPLAY}" -nolisten unix &
exec node /usr/src/app/ -p 80 "$@"
exec node /usr/src/app/ "$@"
fi

exec "$@"
2 changes: 1 addition & 1 deletion docker-entrypoint_light.sh
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#!/bin/sh
if ! which -- "${1}"; then
# first arg is not an executable
exec node /usr/src/app/ -p 80 "$@"
exec node /usr/src/app/ "$@"
fi

exec "$@"

0 comments on commit f242cc1

Please sign in to comment.