MDEV-33091 rename PCRE_INCLUDES to use PKG_CHECK_MODULES naming, PCRE_INCLUDE_DIR #3304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_INCLUDE_DIR The 10.6 server changed the name of the include in commit 3a33ae86010051a1022c392f2936b5fc9f3ab19e. Noticed thanks to Andrew Hutchings
grooverdan
added a commit
to grooverdan/mariadb-server
that referenced
this pull request
Sep 5, 2024
From e735cf2, the PCRE_INCLUDES changed to PCRE_INCLUDE_DIRS for consistency. The columnstore module depends on the old name. Create a mapping for the columnstore submodule. 10.6+ fix for submodule is: * mariadb-corporation/mariadb-columnstore-engine#3304
grooverdan
added a commit
to grooverdan/mariadb-server
that referenced
this pull request
Sep 5, 2024
From e735cf2, the PCRE_INCLUDES changed to PCRE_INCLUDE_DIRS for consistency. The columnstore module depends on the old name. Create a mapping for the columnstore submodule. 10.6+ fix for submodule is: * mariadb-corporation/mariadb-columnstore-engine#3304
5 tasks
grooverdan
added a commit
to MariaDB/server
that referenced
this pull request
Sep 5, 2024
From e735cf2, the PCRE_INCLUDES changed to PCRE_INCLUDE_DIRS for consistency. The columnstore module depends on the old name. Create a mapping for the columnstore submodule. 10.6+ fix for submodule is: * mariadb-corporation/mariadb-columnstore-engine#3304
|
@grooverdan Thx for the patch. |
|
yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…
The 10.6 server changed the name of the include.
ref: MariaDB/server@3a33ae8
Noticed thanks to @LinuxJedi
I also backported the same commit to 10.5 - MariaDB/server#3484 however since its less maintained, appended a workaround mapping for columnstore there.