-
Pagination was implemented as infinite scroll
-
Dismiss post was implemented with react-spring
-
The APP starts the sagas automatically without triggering the initial flow from component effects.
-
I've used two different ways to manage async API calls just to show different ways to manage that:
- Catching the error on the proper requests service and returns mapped objects.
- try / catch block on the sagas generator.
-
The apps allows us for 5 seconds since we press "Dismiss All Posts" button to restore dismissed posts. I used redux-saga solution for that but it could be achieved using redux store for data preservation.
-
The Post Detail Component (Right Side) need to be improved, I'm not manipulating properly the image...
- One big tech debt is moving all inline styles to classes or css objects. I've prioritized other things. We could use Material's techniques like High Order component that allows us to accomplish that. I'm not used material UI spacing so much, this is something we could use more.
- I just add some unit testing for the saga file, I should add more unit testing for all the app.
- Error handling
- We could abstract axios into a single method then reuse it.
- SwipeableDrawer is being mounted / unmounted every time we trigger it, we can could avoid behavior to improve performance and to not lose the scroll position. The scroll position inside the SwipeableDrawer could be achieved using a method of the react-window's List.
- Use Context to avoid prop drilling for swipeable side bar functionality (open and close)
- Animation when dismiss all posts
- Make n attempts on API request before throw an error.
Besides all of that, I hope for you to like it! Thanks!
- react
- redux
- redux-devtools
- redux-saga
- material-ui
- axios
- react-spring
- reselect
In the project directory, you can run:
Runs the app in the development mode.
Open http://localhost:3000 to view it in the browser.
The page will reload if you make edits.
You will also see any lint errors in the console.
Launches the test runner in the interactive watch mode.
See the section about running tests for more information.
Builds the app for production to the build folder.
It correctly bundles React in production mode and optimizes the build for the best performance.
The build is minified and the filenames include the hashes.
Your app is ready to be deployed!
See the section about deployment for more information.
Note: this is a one-way operation. Once you eject, you can’t go back!
If you aren’t satisfied with the build tool and configuration choices, you can eject at any time. This command will remove the single build dependency from your project.
Instead, it will copy all the configuration files and the transitive dependencies (webpack, Babel, ESLint, etc) right into your project so you have full control over them. All of the commands except eject will still work, but they will point to the copied scripts so you can tweak them. At this point you’re on your own.
You don’t have to ever use eject. The curated feature set is suitable for small and middle deployments, and you shouldn’t feel obligated to use this feature. However we understand that this tool wouldn’t be useful if you couldn’t customize it when you are ready for it.
You can learn more in the Create React App documentation.
To learn React, check out the React documentation.
This section has moved here: https://facebook.github.io/create-react-app/docs/code-splitting
This section has moved here: https://facebook.github.io/create-react-app/docs/analyzing-the-bundle-size
This section has moved here: https://facebook.github.io/create-react-app/docs/making-a-progressive-web-app
This section has moved here: https://facebook.github.io/create-react-app/docs/advanced-configuration
This section has moved here: https://facebook.github.io/create-react-app/docs/deployment
This section has moved here: https://facebook.github.io/create-react-app/docs/troubleshooting#npm-run-build-fails-to-minify