-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wip] experimental: tracing panel #3168
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@Light2Dark is attempting to deploy a commit to the marimo Team on Vercel. A member of the Team first needs to authorize it. |
7133e39
to
2b3050c
Compare
status: RunStatus; | ||
} | ||
|
||
export interface Run { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want me to connect this to the backend? i get the backend to return a runId for each cell-op, and get you setup so you can pull this data from state
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah! hmm, I thought it would be more complex but that should work. I'm happy to try connecting it myself 🤔 unless you foresee difficult challenges or decisions.
@Light2Dark i can't figure out how to contribute back to your repo, but you can cherry-pick this commit: 1f58e53 there are some todo and some not implemented stuff. also refreshing / SessionView likely wont work (and likely don't need in the first iteration) |
5e90d14
to
30dc547
Compare
openapi/README.md
Outdated
@@ -0,0 +1,6 @@ | |||
# Modifying the API Specification |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this exists in development docs too. maybe we could consolidate (if needed)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh wow, didn't know this existed. Rest of the PR still needs work, will get to it soon!
📝 Summary
Fixes #2898.
🔍 Description of Changes
todo:
📋 Checklist
📜 Reviewers
@akshayka OR @mscolnick