Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] experimental: tracing panel #3168

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

Light2Dark
Copy link
Contributor

@Light2Dark Light2Dark commented Dec 14, 2024

📝 Summary

Fixes #2898.

🔍 Description of Changes

todo:

  • add a lot more tests :>
  • any ux improvements?
  • empty traces state view (similar to empty logs)
  • icons for queued state
  • there are some warnings in the console from vega

📋 Checklist

  • I have read the contributor guidelines.
  • For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on Discord, or the community discussions (Please provide a link if applicable).
  • I have added tests for the changes made.
  • I have run the code and verified that it works as expected.

📜 Reviewers

@akshayka OR @mscolnick

Copy link

vercel bot commented Dec 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marimo-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 3:59pm
marimo-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 3:59pm

Copy link

vercel bot commented Dec 14, 2024

@Light2Dark is attempting to deploy a commit to the marimo Team on Vercel.

A member of the Team first needs to authorize it.

status: RunStatus;
}

export interface Run {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want me to connect this to the backend? i get the backend to return a runId for each cell-op, and get you setup so you can pull this data from state

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah! hmm, I thought it would be more complex but that should work. I'm happy to try connecting it myself 🤔 unless you foresee difficult challenges or decisions.

@mscolnick
Copy link
Contributor

mscolnick commented Dec 14, 2024

@Light2Dark i can't figure out how to contribute back to your repo, but you can cherry-pick this commit: 1f58e53

there are some todo and some not implemented stuff. also refreshing / SessionView likely wont work (and likely don't need in the first iteration)

@@ -0,0 +1,6 @@
# Modifying the API Specification
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this exists in development docs too. maybe we could consolidate (if needed)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh wow, didn't know this existed. Rest of the PR still needs work, will get to it soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display cell run history
2 participants