-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore disabled fields #108
Ignore disabled fields #108
Conversation
`Backbone.Syphon` is referenced as `Backbone.Syhpon` multiple times.
Fix typo on API Doc
Bump and build v0.6.0
@samccone yes. |
I should have been more clear, it is a good choice to do it in this code path. What do you think @wmadden |
Good point @samccone. I'd still opt to ignore disabled elements by default since that's the behaviour implemented by browsers. I think if someone wants to specifically include their disabled elements they can do so by a) not disabling them (greying them out in CSS for example) or b) opening their own pull request. |
This will take into account whether the input's inside a disabled fieldset, for example.
@samccone I rewrote it using @rhubarbselleven's type selection code. This is now easy for people to customize if they want to. I'm also requesting that you update your |
@samccone any progress here? |
Lgtm 👍 @rhubarbselleven Want to give it the once over |
💥 Thanks guys. |
No description provided.