contenteditable support #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is-docker Allows travis to use docker images for testing
…me-cicular-refs Fixes marionettejs#33
…-checkboxes An indeterminate checkbox will be a null value
Use `$.find`, not `$.children`, to parse nested inputs within a specific form
`Backbone.Syphon` is referenced as `Backbone.Syhpon` multiple times.
Form elements are now fetched with `Syphon.InputFetcher`, instead of
the private `getForm` function. By default, this will fetch `contenteditable`
elements in addition to inputs and checkboxes.
"Content editable" fields are handled as follows:
* must have `contenteditable="true"` (having only `contenteditable` present
is *NOT* sufficient, even though it conforms to the HTML spec)
* must define a `data-name` property, which is used like a standard `input`
field's `name` property
* data in read/written using jQuery's `html()` method
scott-w
requested changes
Feb 8, 2018
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "backbone.syphon", | |||
| "version": "0.7.0", | |||
package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "backbone.syphon", | |||
| "version": "0.7.0", | |||
| "version": "0.7.1", | |||
src/backbone.syphon.js
Outdated
| @@ -149,7 +153,7 @@ var getForm = function(viewOrForm) { | |||
| if (_.isUndefined(viewOrForm.$el)) { | |||
| return $(viewOrForm).find(':input'); | |||
| } else { | |||
| return viewOrForm.$(':input'); | |||
| return viewOrForm.$(':input, [contenteditable]'); | |||
There was a problem hiding this comment.
Have you missed off adding [contenteditable] to the _.isUndefined case above? ☝️
|
@scott-w done 😄 |
scott-w
approved these changes
Feb 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges @davidsulc's work in #113 with the master branch. I have elected to add a new InputReader/Writer for handling
contenteditableelements instead of extending the default.