Form tag no longer required in view and disabled fields are ignored #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 for ignoring disabled inputs, very important. |
|
@samlown Hey, I apologize that this was left for a year. If you're still interested in making these changes to Backbone.Syphon would you mind pulling them into separate pull requests for the form element and disabled inputs? |
This was referenced Apr 23, 2014
|
Cross-reference: #19 |
|
@samlown do you plan on separating this pull-request as @thejameskyle requested? If not, I'll do it. |
|
@rafi I'm quite detached from this at the moment. If you want to go ahead, please do so! |
|
+1 |
|
+1 |
|
|
||
| elements = _.reject(elements, function(el){ | ||
| // Reject disabled fields always | ||
| if (el.hasAttribute('disabled')) { return true; } |
There was a problem hiding this comment.
This should be excluded from this PR.
Cross ref #70
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a remake of my previous pull request #9 for the latest release (0.4.1).
If a form tag is not found in the view, the $(':input') selector will be used instead to find all input fields.
Additionally, disabled fields will be completely ignored, to more closely match a regular HTML form.
Cheers,
sam