Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 3 example apps #391

Merged
merged 3 commits into from
Apr 5, 2015
Merged

Add 3 example apps #391

merged 3 commits into from
Apr 5, 2015

Conversation

jdaudier
Copy link
Contributor

@jdaudier jdaudier commented Apr 4, 2015

@peterblazejewicz There's prob a more graceful way of doing the responsiveness here. Thoughts?

cc/ @samccone @jmeas @thejameskyle - hope it's ok to feature your app

Desktop

image

Tablet

image

Mobile

image

@jdaudier
Copy link
Contributor Author

jdaudier commented Apr 4, 2015

@peterblazejewicz how do I get Travis to pass? I have the latest code pulled down.

@peterblazejewicz
Copy link
Member

@jdaudier that is outstanding issue with Travis CI script:
#375
I've been trying to find out the reason of this error, but yet haven't succeeded.

@peterblazejewicz
Copy link
Member

@peterblazejewicz There's prob a more graceful way of doing the responsiveness here. Thoughts?

@jdaudier there is already .btn-wrapper in place in your code. It should be used to position/offset content using margin-top (currently margin is added to button itself)
Buttons can be simply always display as block, container can be scaled, but not UI elements:
twbs/bootstrap#13647.
So you could do not apply a block style to all buttons, but only apply it under certain breakpoint. That's up to you.

@peterblazejewicz
Copy link
Member

As these are real, existing web objects/applications, I'd add semantic tags to them later, after PR is merged.
👍

@jdaudier
Copy link
Contributor Author

jdaudier commented Apr 4, 2015

@peterblazejewicz I'll leave you to the semantic tags since I'm not exactly sure what you are talking about specifically.

I'll see if I can position the button differently so that I don't have to give a height to the parent container. I wanted all of them to be docked to the bottom & lined up.... which sounded easy but... 👊

@jdaudier
Copy link
Contributor Author

jdaudier commented Apr 4, 2015

@peterblazejewicz refactored the scss to be cleaner

I decided to not line up the buttons and just have it flow naturally

Desktop

image

Tablet

image

Mobile
image

@peterblazejewicz
Copy link
Member

@jdaudier here is another link against applying layouts directly to UI elements:
pure-css/pure#469 (comment)
pure-css/pure#469 (comment)

@jdaudier
Copy link
Contributor Author

jdaudier commented Apr 5, 2015

@peterblazejewicz so you're suggesting removing the margin-top from the btn itself and add it to the btn-wrapper instead?

@peterblazejewicz
Copy link
Member

@jdaudier maybe not yet, but as consideration. Spacing UI elements should be careful. I'd rather use container and space it per design. Bootstrap does not space buttons, except of specific use-case: http://git.io/veWEc while Foundation adds bottom margin to all buttons: http://git.io/veWER

@jdaudier
Copy link
Contributor Author

jdaudier commented Apr 5, 2015

Ok... looks good to merge?

peterblazejewicz added a commit that referenced this pull request Apr 5, 2015
Add 3 example apps
Tested PR/391 locally with `grunt compile-all` option
@peterblazejewicz peterblazejewicz merged commit 878e85c into marionettejs:master Apr 5, 2015
@jdaudier jdaudier deleted the add/example-apps branch April 5, 2015 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants