-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 3 example apps #391
Add 3 example apps #391
Conversation
@peterblazejewicz how do I get Travis to pass? I have the latest code pulled down. |
@jdaudier there is already |
As these are real, existing web objects/applications, I'd add semantic tags to them later, after PR is merged. |
@peterblazejewicz I'll leave you to the I'll see if I can position the button differently so that I don't have to give a height to the parent container. I wanted all of them to be docked to the bottom & lined up.... which sounded easy but... 👊 |
@peterblazejewicz refactored the scss to be cleaner I decided to not line up the buttons and just have it flow naturally Desktop Tablet |
@jdaudier here is another link against applying layouts directly to UI elements: |
@peterblazejewicz so you're suggesting removing the margin-top from the btn itself and add it to the btn-wrapper instead? |
@jdaudier maybe not yet, but as consideration. Spacing UI elements should be careful. I'd rather use container and space it per design. Bootstrap does not space buttons, except of specific use-case: http://git.io/veWEc while Foundation adds bottom margin to all buttons: http://git.io/veWER |
Ok... looks good to merge? |
Add 3 example apps Tested PR/391 locally with `grunt compile-all` option
@peterblazejewicz There's prob a more graceful way of doing the responsiveness here. Thoughts?
cc/ @samccone @jmeas @thejameskyle - hope it's ok to feature your app
Desktop
Tablet
Mobile