Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency version that broke build #432

Merged
merged 1 commit into from
Dec 31, 2015
Merged

Update dependency version that broke build #432

merged 1 commit into from
Dec 31, 2015

Conversation

jdaudier
Copy link
Contributor

@trezy I had to change this back since it broke my build.

@jdaudier jdaudier changed the title Update dependency versions that broke build Update dependency version that broke build Dec 26, 2015
@trezy
Copy link
Member

trezy commented Dec 26, 2015

Coolies. As long as the build passes (I restarted it) 👍

@jdaudier
Copy link
Contributor Author

@trezy: build failed... Why?

@trezy
Copy link
Member

trezy commented Dec 26, 2015

Just looking at the log in Travis, I have no idea. I can take a look later if nobody else has figured it out.

@peterblazejewicz
Copy link
Member

I think Sam can have some insight on this:
#375
That is wrapper code around non-standard exit code on Linux I think

@jdaudier
Copy link
Contributor Author

@samccone any idea? Should I merge even if build fails?

@samccone
Copy link
Member

yep I will take a look here :)

@jdaudier
Copy link
Contributor Author

Any luck @samccone? Tks!

@samccone
Copy link
Member

@jdaudier @peterblazejewicz @trezy do any of you have a version that works locally?

if possible can you run npm shrinkwrap and put that file in a gist for me? (and tell me your node version)

@peterblazejewicz
Copy link
Member

@samccone
Done: https://gist.github.com/peterblazejewicz/370fdf1a49301366cd27
I had to make a small change in package.json though: #433

@jdaudier
Copy link
Contributor Author

@samccone
Copy link
Member

landing this

samccone added a commit that referenced this pull request Dec 31, 2015
Update dependency version that broke build
@samccone samccone merged commit 3a43ca2 into marionettejs:master Dec 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants