Make PageSpeed Insights part of CI #486
Conversation
| port: port, | ||
| options: { | ||
| //@todo up it to 85-90 when pages speed will be fixed | ||
| threshold: 10 |
There was a problem hiding this comment.
What's the impact on testing runtime?
There was a problem hiding this comment.
I think impact is not so much but it worth it. Right now we have issue about page speed #394 After fixing it I really don't wanna go back and fix it once more. If someone propose changes which downgrade pagespeed then CI automatically fail it.
There was a problem hiding this comment.
Or maybe you asking about purpose of adding threshold: 10 so low. I think to add PSI asap to already have it. threshold can be increased after next pr's with pagespeed fixes.
Also it helpful for testing during developing pagespeed fixes.
There was a problem hiding this comment.
I think I was referring more to your TODO there - it sounds like PageSpeed is having some impact on the build times and I was curious as to whether it would cause issues in future.
With the threshold being low, what's needed to bring it up?
There was a problem hiding this comment.
Ideally pages have to have threshold about 85, but right now on some pages it's lower. So value is set threshold: 10 to successfully pass the build process. When page speed will be fixed we can up it.
Other then that, it will be not run during deploy, so it's only just for checking new changes.
There was a problem hiding this comment.
Ohh I see, it's related to scoring. For some reason I though threshold was related to a number of pages to run through it! My bad :P
|
@denar90 Artem, still valid? I want to merge this PR |
|
@peterblazejewicz I think so. If nobody against it, I would love to have it merged. |
Related to #485