Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for custom IHostService creation in HostBuilder #186

Merged
merged 1 commit into from
Mar 28, 2021

Conversation

mariotoffia
Copy link
Owner

Add methods:

  • FromUri that uses a DockerUri to create a IHostService. This uri is arbitary. It also support other properties (see below).
   public HostBuilder FromUri(
      DockerUri uri,
      string name = null,
      bool isNative = true,
      bool stopWhenDisposed = false,
      bool isWindowsHost = false,
      string certificatePath = null) {/*...*/}

It will use "sensible" defaults on all parameters. Most of the case the uri is sufficient. For example if not providing the certificatePath it will try to get it from the environment DOCKER_CERT_PATH. If not found in the environment, it will default to none.

  • UseHost that takes a instantiated IHostService implementation.

this closes isse #185

Both supports creation of custom IHostService.
@mariotoffia mariotoffia merged commit ecfb44b into master Mar 28, 2021
@mariotoffia mariotoffia deleted the feature-custom-host branch July 19, 2022 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant