Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2020-01-26 Updates #105

Merged
merged 2 commits into from
Jan 28, 2020
Merged

Conversation

nmay231
Copy link
Contributor

@nmay231 nmay231 commented Jan 27, 2020

Just hacking away at #104

@nmay231
Copy link
Contributor Author

nmay231 commented Jan 27, 2020

@markerikson
I also looked at some of the other PRs and #90, #92, and #93 are formated correctly and not duplicates (90 should probably be squashed when merged)

And if you would like, I could also use a script to label any duplicates. I could also adjust links for any redirects. Let me know if that's good with you 👍

Also, what do you think of reorganizing the lists to be ordered alphabetically? That seems like a lot of work though... 😐

@markerikson
Copy link
Owner

I don't want to reorder things in the Markdown. However, I'd definitely still be interested in having a browseable site that uses these Markdown files as a scrapeable source and then pulls in more info.

@markerikson markerikson merged commit 53e8c49 into markerikson:master Jan 28, 2020
@nmay231 nmay231 deleted the 2020-01-26-updates branch January 28, 2020 02:55
@nmay231
Copy link
Contributor Author

nmay231 commented Jan 28, 2020

Speaking of which, some of the issues with the parser for the website were due to it not being lenient enough, e.g. not allowing more than one link per project. Those just need to get fixed

But there were other errors because of formatting issues/nuances. Like in middleware-network-requests.md, the General section is an h3 instead of an h4.

I'll fix the issues that it should obviously handle first, and we can look over the rest to see what's up.

@nmay231 nmay231 mentioned this pull request Jan 27, 2020
97 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants