remove default value for $package_version

Setting the default value to 'present' promotes the wrong approach.
The module *needs* the version number in order to enable or disable
certain incompatible configurations/features.

README.md

@@ -31,21 +31,17 @@ This module manages the installation and configuration of Artifactory.
 
 ## Setup
 
-### Beginning with artifactory
+### Basic usage
 
-If you want a server installed with the default options you can run
-`include 'artifactory'`.
-
-However, it is strongly recommended to specify the desired version of Artifactory:
+To setup Artifactory with default options only the desired version needs to be specified:
 
 ```puppet
 class { 'artifactory':
-  package_version => '7.4.3',
+  package_version => '7.90.7',
+}
 ```
 
-This ensures that the module behaves correctly and does not enable obsolete features for your version of Artifactory.
-
-If you need to add database connectivity instantiate with the required parameters:
+### Complex example
 
 ```puppet
 class { 'artifactory':
@@ -55,6 +51,7 @@ class { 'artifactory':
   db_username                    => 'my_username',
   db_password                    => 'efw23gn2j3',
   binary_provider_type           => 'filesystem',
+  package_version                => '7.90.7',
   pool_max_active                => 100,
   pool_max_idle                  => 10,
   binary_provider_cache_maxsize  => $binary_provider_cache_maxsize,
@@ -69,8 +66,9 @@ To install a commercial version of Artifactory:
 
 ```puppet
 class { 'artifactory':
-  edition     => 'pro',
-  license_key => 'ABCDEFG1234567890',
+  edition         => 'pro',
+  license_key     => 'ABCDEFG1234567890',
+  package_version => '7.90.7',
   ...
 }
 ```

REFERENCE.md

@@ -316,7 +316,9 @@ Sets the package name to install (Pro edition).
 
 Data type: `String`
 
-Specifies the package version.
+Specifies the package version. It is highly recommended to set it to
+a real version number. Setting the value to `present` may lead to a
+broken config.
 
 ##### <a name="-artifactory--pool_max_active"></a>`pool_max_active`
 

data/common.yaml

@@ -13,7 +13,6 @@ artifactory::install_service_script: 'app/bin/installService.sh'
 artifactory::manage_repo: true
 artifactory::package_name: 'jfrog-artifactory-oss'
 artifactory::package_name_pro: 'jfrog-artifactory-pro'
-artifactory::package_version: 'present'
 artifactory::root_password: 'password'
 artifactory::service_name: 'artifactory'
 artifactory::symlink_name: 'artifactory'

manifests/init.pp

@@ -105,7 +105,9 @@
 #   Sets the package name to install (Pro edition).
 #
 # @param package_version
-#   Specifies the package version.
+#   Specifies the package version. It is highly recommended to set it to
+#   a real version number. Setting the value to `present` may lead to a
+#   broken config.
 #
 # @param pool_max_active
 #   Maximum number of pooled database connections.

spec/acceptance/class_spec.rb

@@ -4,7 +4,9 @@
   context 'with default parameters' do
     it 'works with no errors' do
       pp = <<-ARTIFACTORY_TEST
-      class { 'artifactory': }
+      class { 'artifactory':
+        package_version => '7.90.7',
+      }
       ARTIFACTORY_TEST
 
       # Run it twice and test for idempotency
@@ -49,12 +51,14 @@ class {'postgresql::globals':
         user     => 'artifactory',
         password => postgresql::postgresql_password('artifactory', '45y43y58y435hitr'),
       }
+
       class { 'artifactory':
-        db_type     => 'postgresql',
-        db_username => 'artifactory',
-        db_password => '45y43y58y435hitr',
-        db_url      => 'jdbc:postgresql:127.0.0.1:5432/artifactory',
-        require     => Postgresql::Server::Db['artifactory']
+        db_type         => 'postgresql',
+        db_username     => 'artifactory',
+        db_password     => '45y43y58y435hitr',
+        db_url          => 'jdbc:postgresql:127.0.0.1:5432/artifactory',
+        package_version => '7.90.7',
+        require         => Postgresql::Server::Db['artifactory']
       }
       PUPPETCODE