Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle errors, add go.mod, add .gitignore #9

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

f-ewald
Copy link

@f-ewald f-ewald commented May 19, 2022

I added a go.mod and I propose to use go modules going forward. I also made the project dependent on go 1.18 as I am planning to make further changes that will require a fairly recent version, mostly //go:embed. .gitignore was added because I am importing this into my IDE.

Please let me know what you think about these changes and if I can contribute further.

Copy link
Owner

@marouni marouni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx @f-ewald for your suggestion and efforts.

I'll take some in the coming days to build and test the changes.

Do you see any Readme chages worth mentioning ?

go.mod Outdated
@@ -0,0 +1,17 @@
module github.com/f-ewald/adr
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@f-ewald Would it be possible to put the /marouni/ path here ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I will change this.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx @f-ewald
I'll rebuild test and get back to you ASAP

@f-ewald f-ewald requested a review from marouni November 22, 2022 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants