-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle errors, add go.mod, add .gitignore #9
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx @f-ewald for your suggestion and efforts.
I'll take some in the coming days to build and test the changes.
Do you see any Readme chages worth mentioning ?
go.mod
Outdated
@@ -0,0 +1,17 @@ | |||
module github.com/f-ewald/adr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@f-ewald Would it be possible to put the /marouni/ path here ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I will change this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx @f-ewald
I'll rebuild test and get back to you ASAP
I added a
go.mod
and I propose to use go modules going forward. I also made the project dependent on go 1.18 as I am planning to make further changes that will require a fairly recent version, mostly//go:embed
..gitignore
was added because I am importing this into my IDE.Please let me know what you think about these changes and if I can contribute further.