Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sorted vsriables #1982

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

sorted vsriables #1982

wants to merge 1 commit into from

Conversation

SuperKros
Copy link

No description provided.

mateacademy-ai-mentor
mateacademy-ai-mentor approved these changes Nov 26, 2024
View reviewed changes
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on categorizing the variables correctly into mutable and immutable types! 🎉 Your implementation meets the task requirements and constraints perfectly. Keep up the good work and continue honing your skills! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

petrykivd
petrykivd suggested changes Nov 27, 2024
View reviewed changes
Copy link

@petrykivd petrykivd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the problem with flake8, don't forget the empty line at the end of the file.

app/main.py
Comment on lines 18 to +22

# write your code here
sorted_variables = {
"mutable": [marks, my_favourite_films, collection_of_coins],
"immutable": [name, profile_info, one_is_a_prime_number, lucky_number, pi]
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the problem with flake8, don't forget the empty line at the end of the file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrykivd petrykivd petrykivd requested changes

@mateacademy-ai-mentor mateacademy-ai-mentor mateacademy-ai-mentor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SuperKros @petrykivd @mateacademy-ai-mentor