Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we make not_near_at_rightP an equivalence? #1273

Open
Yosuke-Ito-345 opened this issue Jul 27, 2024 · 3 comments
Open

Should we make not_near_at_rightP an equivalence? #1273

Yosuke-Ito-345 opened this issue Jul 27, 2024 · 3 comments

Comments

@Yosuke-Ito-345
Copy link
Contributor

Yosuke-Ito-345 commented Jul 27, 2024

In the theory normedtype.v, we have the lemma not_near_at_rightP.
The name contains the character P, but it states one-direct implication, not the equivalence.
For me, this seems contradictory to the naming convention stated in
https://github.com/math-comp/math-comp/blob/master/CONTRIBUTING.md
Should we add the other direction of not_near_at_rightP and make it an equivalence?
(This is also the case with not_near_at_leftP.)

@Yosuke-Ito-345 Yosuke-Ito-345 changed the title Should we make Lemma not_near_at_rightP an equivalence? Should we make not_near_at_rightP an equivalence? Jul 27, 2024
@affeldt-aist
Copy link
Member

Fixed by PR #1291

@affeldt-aist
Copy link
Member

affeldt-aist commented Sep 21, 2024

I have closed this issue by mistake (@Yosuke-Ito-345: thanks for noticing).

@affeldt-aist affeldt-aist reopened this Sep 21, 2024
@Yosuke-Ito-345
Copy link
Contributor Author

In the Section at_left_right in normedtype.v, the Variable R is assumed to be numFieldType.
Isn't it more rational to assume R to be realDomainType?
I think left and right have meanings only when the type is totally ordered.
I suggest this alternative because I would like to freely use the following lemma

ler_norm: forall [R : realDomainType] (x : R), x <= `|x|

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants