Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the lemma not_near_ninftyP in normedtype.v #1280

Conversation

Yosuke-Ito-345
Copy link
Contributor

Motivation for this change

@affeldt-aist
Add an infinite version of the lemma not_near_at_rightP in normedtype.v.
Tell me if I should write a change log in CHANGELOG_UNRELEASED.md.

Checklist
  • added corresponding entries in CHANGELOG_UNRELEASED.md
  • added corresponding documentation in the headers

Reference: How to document

Reminder to reviewers

@hoheinzollern
Copy link
Collaborator

Nice work!
I'm unsure about the naming, since the P suffix suggests that you move between bool and prop, but the lemma actually changes the statement.
Once the naming is settled, you can add that to CHANGELOG_UNRELEASED.md on a new line.

@Yosuke-Ito-345
Copy link
Contributor Author

@hoheinzollern
Thank you for the review!
I know that P is often used for reflection lemmas, but I adopted the suffix for the following reasons.

  1. The contributing guide of mathcomp says that P can be used for a characteristic property.
  2. The similar lemma not_near_at_rightP uses the same suffix, but this is not a reflection lemma.

If P should not be used in my case, that probably means I misunderstand something. Do I really need to drop P?

@hoheinzollern
Copy link
Collaborator

Ok, that's a pretty valid argument. Would it make sense to add a similar lemma for not_near_inftyP?

@Yosuke-Ito-345
Copy link
Contributor Author

Yosuke-Ito-345 commented Aug 8, 2024

Thank you very much.
As you pointed out, I will add the lemma not_near_inftyP after this pull request is approved.
I also consider generalizing the lemmas not_near_at_rightP and not_near_at_leftP (cf. issue #1723).

I added my lemma in CHANGELOG_UNRELEASED.md, but GitHub says that there are conflicts. Should I make another changelog file?

@affeldt-aist
Copy link
Member

It is maybe better if you provide all the similar-looking lemmas in the same PR: their mutual comparison could help figure out better names and potential factorizations.

As for the changelog conflict, you can do a rebase.

@Yosuke-Ito-345
Copy link
Contributor Author

All right. Thanks for the advice.
I will formalize not_near_inftyP later, and reflect it to this pull request.

@Yosuke-Ito-345
Copy link
Contributor Author

Sorry, I could not solve my conflict problem by rebase.
(Maybe I did something completely wrong, but I am not sure...)

I created a new pull request, so could you please review the new one?
I will delete this pull request (#1280) when everything has done.

@affeldt-aist
Copy link
Member

note that you can add closes issue #1280 to the PR message of the new PR to close this issue automatically

@affeldt-aist affeldt-aist added the wontfix/merge 🚫 We wont fix this issue/merge this PR, we will close it soon label Aug 11, 2024
@Yosuke-Ito-345
Copy link
Contributor Author

I didn't know that!
Thanks for teaching me such a convenient command.

@affeldt-aist
Copy link
Member

the same contents have made their way into master through the merged PR #1291

@Yosuke-Ito-345 Yosuke-Ito-345 deleted the Add-Lemma_not_near_ninftyP branch August 27, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix/merge 🚫 We wont fix this issue/merge this PR, we will close it soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants