Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lemma gt0_ltr_powR #1027

Merged
merged 2 commits into from
Oct 2, 2023
Merged

Conversation

hoheinzollern
Copy link
Collaborator

@hoheinzollern hoheinzollern commented Sep 23, 2023

Motivation for this change
  • Adds lemma gt0_ltr_powR
  • Renames gt0_ler_powR to ge0_ler_powR
  • Introduces powR_injective
Things done/to do
  • added corresponding entries in CHANGELOG_UNRELEASED.md
  • added corresponding documentation in the headers
Compatibility with MathComp 2.0
  • I added the label TODO: HB port to make sure someone ports this PR to
    the hierarchy-builder branch or I already opened an issue or PR (please cross reference).
Automatic note to reviewers

Read this Checklist and put a milestone if possible.

@affeldt-aist
Copy link
Member

The last commit introduces powR_injective which shortens the proof of gtr0_ltr_powR.

@affeldt-aist
Copy link
Member

About a related lemma: shouldn't gt0_ler_powR have been called ge0_ler_powR?

@affeldt-aist affeldt-aist added this to the 0.6.5 milestone Sep 28, 2023
@affeldt-aist affeldt-aist added the enhancement ✨ This issue/PR is about adding new features enhancing the library label Sep 28, 2023
@affeldt-aist affeldt-aist added the TODO: MC2 port This PR must be ported to mathcomp 2 now that the. Remove this label when the port is done. label Oct 1, 2023
@affeldt-aist affeldt-aist self-requested a review October 1, 2023 08:48
@affeldt-aist
Copy link
Member

Since it contains a fix and adds a variation of an existing lemma, I think that we can merge it.

@affeldt-aist affeldt-aist merged commit 3381621 into math-comp:master Oct 2, 2023
30 checks passed
affeldt-aist added a commit to affeldt-aist/analysis that referenced this pull request Oct 2, 2023
* Lemma gt0_ltr_powR

* add powR_injective

---------

Co-authored-by: Reynald Affeldt <[email protected]>
affeldt-aist added a commit to affeldt-aist/analysis that referenced this pull request Oct 10, 2023
* Lemma gt0_ltr_powR

* add powR_injective

---------

Co-authored-by: Reynald Affeldt <[email protected]>
affeldt-aist added a commit that referenced this pull request Oct 11, 2023
* Lemma gt0_ltr_powR

* add powR_injective

---------

Co-authored-by: Reynald Affeldt <[email protected]>
IshiguroYoshihiro pushed a commit to IshiguroYoshihiro/analysis that referenced this pull request Oct 24, 2023
* Lemma gt0_ltr_powR

* add powR_injective

---------

Co-authored-by: Reynald Affeldt <[email protected]>
@proux01 proux01 removed the TODO: MC2 port This PR must be ported to mathcomp 2 now that the. Remove this label when the port is done. label Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ This issue/PR is about adding new features enhancing the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants