Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes 1042, 1037, 1045, 1046 #1043

Merged
merged 4 commits into from
Oct 9, 2023
Merged

Conversation

affeldt-aist
Copy link
Member

@affeldt-aist affeldt-aist commented Oct 3, 2023

Motivation for this change

fixes #1042

fixes #1037

fixes #1045

fixes #1046

Things done/to do
  • added corresponding entries in CHANGELOG_UNRELEASED.md

- [ ] added corresponding documentation in the headers

Compatibility with MathComp 2.0
  • I added the label TODO: HB port to make sure someone ports this PR to
    the hierarchy-builder branch or I already opened an issue or PR (please cross reference).
Automatic note to reviewers

Read this Checklist and put a milestone if possible.

@affeldt-aist affeldt-aist added the TODO: MC2 port This PR must be ported to mathcomp 2 now that the. Remove this label when the port is done. label Oct 3, 2023
@affeldt-aist affeldt-aist added this to the 0.6.6 milestone Oct 3, 2023
@affeldt-aist affeldt-aist changed the title Fixes 1042 Fixes 1042 and 1037 Oct 3, 2023
@affeldt-aist affeldt-aist changed the title Fixes 1042 and 1037 Fixes 1042, 1037, 1045, 1046 Oct 5, 2023
@proux01
Copy link
Collaborator

proux01 commented Oct 5, 2023

@affeldt-aist a rebase should fix the CI (I hope)

@affeldt-aist
Copy link
Member Author

@affeldt-aist a rebase should fix the CI (I hope)

indeed

@affeldt-aist affeldt-aist requested a review from proux01 October 8, 2023 11:22
@proux01 proux01 merged commit 86915bf into math-comp:master Oct 9, 2023
0 of 30 checks passed
@proux01 proux01 removed the TODO: MC2 port This PR must be ported to mathcomp 2 now that the. Remove this label when the port is done. label Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gt0_fin_numE more appropriate section name ball_filter can be generalized Lnorm should be locked
2 participants