Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expeR #1047

Merged
merged 6 commits into from
Nov 10, 2023
Merged

expeR #1047

merged 6 commits into from
Nov 10, 2023

Conversation

hoheinzollern
Copy link
Collaborator

@hoheinzollern hoheinzollern commented Oct 5, 2023

Motivation for this change

Introduces expeR and related lemmas

Co-authored-by: @ndslusarz
Co-authored-by: @affeldt-aist

Things done/to do
  • added corresponding entries in CHANGELOG_UNRELEASED.md
  • added corresponding documentation in the headers
Compatibility with MathComp 2.0
  • I added the label TODO: HB port to make sure someone ports this PR to
    the hierarchy-builder branch or I already opened an issue or PR (please cross reference).
Automatic note to reviewers

Read this Checklist and put a milestone if possible.

@hoheinzollern hoheinzollern marked this pull request as draft October 5, 2023 08:44
@affeldt-aist affeldt-aist added the TODO: MC2 port This PR must be ported to mathcomp 2 now that the. Remove this label when the port is done. label Nov 10, 2023
@affeldt-aist affeldt-aist marked this pull request as ready for review November 10, 2023 06:49
@affeldt-aist affeldt-aist self-requested a review November 10, 2023 06:49
Copy link
Member

@affeldt-aist affeldt-aist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a bit of linting, add changelog and doc, and fix another unrelated minor issue. That is ok with me.

@affeldt-aist affeldt-aist merged commit f95786b into math-comp:master Nov 10, 2023
30 checks passed
affeldt-aist pushed a commit to affeldt-aist/analysis that referenced this pull request Nov 14, 2023
* initial development of expeR

fixes math-comp#1086
---------
Co-authored-by: @ndslusarz
Co-authored-by: Reynald Affeldt <[email protected]>
proux01 pushed a commit that referenced this pull request Nov 15, 2023
* initial development of expeR

fixes #1086
---------
Co-authored-by: @ndslusarz
Co-authored-by: Reynald Affeldt <[email protected]>
@proux01 proux01 removed the TODO: MC2 port This PR must be ported to mathcomp 2 now that the. Remove this label when the port is done. label Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants