-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expeR #1047
Merged
Merged
expeR #1047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: @ndslusarz
fixes math-comp#1086
affeldt-aist
added
the
TODO: MC2 port
This PR must be ported to mathcomp 2 now that the. Remove this label when the port is done.
label
Nov 10, 2023
affeldt-aist
approved these changes
Nov 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a bit of linting, add changelog and doc, and fix another unrelated minor issue. That is ok with me.
affeldt-aist
pushed a commit
to affeldt-aist/analysis
that referenced
this pull request
Nov 14, 2023
* initial development of expeR fixes math-comp#1086 --------- Co-authored-by: @ndslusarz Co-authored-by: Reynald Affeldt <[email protected]>
proux01
pushed a commit
that referenced
this pull request
Nov 15, 2023
* initial development of expeR fixes #1086 --------- Co-authored-by: @ndslusarz Co-authored-by: Reynald Affeldt <[email protected]>
proux01
removed
the
TODO: MC2 port
This PR must be ported to mathcomp 2 now that the. Remove this label when the port is done.
label
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Introduces
expeR
and related lemmasCo-authored-by: @ndslusarz
Co-authored-by: @affeldt-aist
Things done/to do
CHANGELOG_UNRELEASED.md
Compatibility with MathComp 2.0
TODO: HB port
to make sure someone ports this PR tothe
hierarchy-builder
branch or I already opened an issue or PR (please cross reference).Automatic note to reviewers
Read this Checklist and put a milestone if possible.